Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Avoid redefinition of default color materials #1281

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Avoid redefinition of default color materials #1281

merged 1 commit into from
Sep 26, 2024

Conversation

Masa0u0
Copy link
Contributor

@Masa0u0 Masa0u0 commented Sep 26, 2024

I want to prevent ItemIdentityException when trying to create multiple rviz_common::VisualizationFrame instances in a single process.

@Masa0u0 Masa0u0 requested a review from ahcorde as a code owner September 26, 2024 01:03
@ahcorde
Copy link
Contributor

ahcorde commented Sep 26, 2024

Pulls: #1281
Gist: https://gist.githubusercontent.com/ahcorde/bdb993ac45f62a715df2fa025963b0c6/raw/22aa69d80436b773f2f72dbeee69ea1b5ead620a/ros2.repos
BUILD args: --packages-above-and-dependencies rviz_rendering --packages-above-and-dependencies rviz_rendering
TEST args: --packages-above-and-dependencies rviz_rendering --packages-above rviz_rendering
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14620

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 8e757c2 into ros2:rolling Sep 26, 2024
2 checks passed
@ahcorde
Copy link
Contributor

ahcorde commented Sep 26, 2024

https://github.com/Mergifyio backport jazzy

@mergify Mergify
Copy link

mergify bot commented Sep 26, 2024 •
edited
Loading

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 26, 2024
@Masa0u0 @mergify
Avoid redefinition of default color materials (#1281)
6815285 
(cherry picked from commit 8e757c2)
@mergify mergify bot mentioned this pull request Sep 26, 2024
Merged
ahcorde pushed a commit that referenced this pull request Sep 26, 2024
@mergify @Masa0u0
Avoid redefinition of default color materials (#1281) (#1282)
591594e 
(cherry picked from commit 8e757c2)

Co-authored-by: Masayoshi Dohi <66519864+Masa0u0@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Masa0u0 @ahcorde