replace original file and rebuilt index after merge #255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have two ideas for this function:
After the merge is completed, replace the file and rebuild the index from disk.
Advantages: Memory usage does not increase.
Disadvantages: The whole process requires a write lock, and the db cannot be read or written externally.
Put the written index data into the temporary storage area during the merge process (like copy-on-write), and build an index while building the hint file. When the merge ends, the index of the temporary storage area and the hint index to combine.
Advantages: DB's write lock time is smooth and can be merged smoothly.
Disadvantage: There may be more than twice the memory overhead.
Based on the shortcomings of bitcase, I chose the first option.