Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

PdfBoxGraphics2DFontTextDrawer.iterateRun - off-by-one leads to wrong font style #27

Closed
kiwiwings opened this issue Nov 8, 2020 · 3 comments
Closed

PdfBoxGraphics2DFontTextDrawer.iterateRun - off-by-one leads to wrong font style #27

kiwiwings opened this issue Nov 8, 2020 · 3 comments

Comments

@kiwiwings
Copy link

The TextDrawer has a off-by-one which leads to shifted font styles in text mode - in shape mode it works correctly.

Please apply the patch

If you provide a new release by December '20, I'm happy to include it in Apache POI, as we use your library now to render powerpoint slides to PDF ... otherwise I just use the copied class - Thank you for your great implementation!
@kiwiwings
Copy link
Author

Sorry ... there seems to be another error. it switches now to shape mode and I've missed that before ... I'll provide another patch when fixed.

@kiwiwings
Copy link
Author

ok this patch looks better

rototor added a commit that referenced this issue Nov 9, 2020
@rototor
Testcase for #27, which shows the problem.
d719c7c
rototor added a commit that referenced this issue Nov 9, 2020
@rototor
Fix for #27 as provided by @kiwiwings
d091b5b
@rototor
Copy link
Owner

rototor commented Nov 9, 2020

I've just released version 0.28 with your fix. Thanks for pointing out this problem.

@rototor rototor closed this as completed Nov 9, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rototor @kiwiwings