AWS fixes #270
Merged
AWS fixes #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't require params and headers objects in awss3 config
|
@ejucovy Thanks for your contribution. Really didn't got much time to review and merge your contribution due to busy schedule. Tonight I'll spare some time, merge and release updated version. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send contentType and filePath in request to s3 signing URL -- currently these are omitted -- only awss3.params are sent
Don't require params and headers objects in awss3 config -- currently results in a confusing "Network Error : Could not send request to AWS. (Maybe CORS error)" error before any network requests are made because e.g.
Object.entries(config.params)throws an exception if config.params is undefined