Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix README, add RdpControl.OnClientAreaClicked event and fix InvalidActiveXStateException in RdpControl.Disconnect #6

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

haefele
Copy link
Contributor

@haefele haefele commented Apr 10, 2024

Hey, just some small things I noticed while using the library.

  • The README referenced your other package for FreeRDP in some places.
  • I also noticed that there was no RdpControl.OnClientAreaClicked event, but all other events of the RdpClient are available through the RdpControl (Connected, Disconnected, etc.)
  • And I also experienced a InvalidActiveXStateException in RdpControl.Disconnect() method when the underlying Ocx control was still NULL. The code in that method seems very defensive, so this additional check makes sense to avoid the exception.

Just some small things, but would be appreciated if you could merge it 😄

@StefanKoell StefanKoell merged commit db0d8b3 into royalapplications:main Apr 11, 2024
1 check failed
@StefanKoell
Copy link
Member

Thanks for the PR!

@haefele haefele deleted the patch-2 branch August 8, 2024 09:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants