Update a few things. #6
Conversation
| @@ -114,6 +114,11 @@ ByteBuffer.prototype.writeRrsInt32 = function(value, offset) { | |||
| } | |||
| return size; | |||
| }; | |||
| */ | |||
| ByteBuffer.prototype.writeRrsInt32 = () => { | |||
| process.emitWarning("writeRrsInt32 is depreciated."); | |||
There was a problem hiding this comment.
I believe you mean "deprecated" not "depreciated"
There was a problem hiding this comment.
I will fix these typos in the next pr
| @@ -1,3 +1,3 @@ | |||
| { | |||
| "serverKey": "ac30dcbea27e213407519bc05be8e9d930e63f873858479946c144895fa3a26b" | |||
| "serverKey" : "980CF7BB7262B386FEA61034ABA7370613627919666B34E6ECF66307A381DD61" | |||
| @@ -17,12 +17,14 @@ | |||
| "node": ">=6.8.0" | |||
| }, | |||
| "dependencies": { | |||
| "blake2": "^1.4.0", | |||
| "blakejs": "github:dcposch/blakejs", | |||
There was a problem hiding this comment.
Why switch dependency, and why not use the published npm module?
There was a problem hiding this comment.
Because a lot of people have problems with compiling blake2 with node-gyp, especially on Windows. Enter blakejs - a pure JavaScript impl of blake2.
| path = require('path'), | ||
| jsome = require('jsome'), | ||
| colors = require('colors'), | ||
| jsbytes = require('jsbytes'), |
There was a problem hiding this comment.
This is going to be used instead of some things ByteBuffer does; as I mentioned in my PR comment, I am in the middle of removing ByteBuffer deps
- Xzlash
There was a problem hiding this comment.
Also I am aware that some styling is inconsistent, I will fix this once I fix ByteBuffer, but this will not be for some time
I am in the middle of removing ByteBuffer deps, but this will have to wait until the next PR.