Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

spec: If DNF5 obsoletes DNF, do not build dnf-automatic #2129

Conversation

ppisar
Copy link
Contributor

@ppisar ppisar commented Sep 11, 2024

Fedora CI rpmdeplint test failed for dnf-automic in Fedora 42 because dnf5-plugin-automatic package obsoletes dnf-automatic package there:

Upgrade problems:
dnf-automatic-4.21.1-1.fc42.noarch would be obsoleted by dnf5-plugin-automatic-5.2.5.0-2.fc41.x86_64 from repo fedora-42-x86_64

This patch fixes it by not building dnf-automatic package if a macro for obsoleting dnf by dnf5 is set. (Similar to a previous f519e60 commit.)

Fedora CI rpmdeplint test failed for dnf-automic in Fedora 42 because
dnf5-plugin-automatic package obsoletes dnf-automatic package there:

    Upgrade problems:
    dnf-automatic-4.21.1-1.fc42.noarch would be obsoleted by dnf5-plugin-automatic-5.2.5.0-2.fc41.x86_64 from repo fedora-42-x86_64

This patch fixes it by not building dnf-automatic package if a macro
for obsoleting dnf by dnf5 is set. (Similar to a previous
f519e60 commit.)
@ppisar ppisar force-pushed the do_no_build_obsolete_dnf_automatic branch from 094e23b to 2260693 Compare September 11, 2024 12:39
@jan-kolarik jan-kolarik self-assigned this Sep 23, 2024
Copy link
Member

@jan-kolarik jan-kolarik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the 1 failing microdnf test is unrelated.

@jan-kolarik
Copy link
Member

Thanks!

@jan-kolarik jan-kolarik merged commit d50a6b2 into rpm-software-management:master Sep 23, 2024
7 of 11 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants