[FIX] -- job status display in scheduler listing page template. #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,7 +93,7 @@ | |||
| {{ job.ended_at|to_localtime|date:"Y-m-d, H:i:s" }} | |||
| {% endif %} | |||
| </td> | |||
| <td>{{ job.get_status }}</td> | |||
| <td>{{ job.get_status.value }}</td> | |||
|
Hey @selwin, Any updates on this? Does this fix require test cases? I don't think so, as it's just a template frontend-side value change. |
|
No tests is necessary since you provided a screenshot, but can you make sure that all tests pass? |
|
All tests on current master now pass. Try rebasing? |
Sure will do it today :) EDIT: Done ✅ |
DhavalGojiya
force-pushed
the
bugfix/job-status-display
branch
from
8e91e2b to
ab68ce0
Compare
- Updated 'job.get_status' to 'job.get_status.value' in 'scheduler.html' to correctly display the job status. - This affects the scheduler view at '/django-rq/schedulers/<scheduler_id>/'.
DhavalGojiya
force-pushed
the
bugfix/job-status-display
branch
from
ab68ce0 to
07d3a2a
Compare
|
@DhavalGojiya the tests still failed, did you look at the failing test to see what went wrong? |
I think the issue is on GitHub Actions' side. The Docker pull image rate limit API has been exceeded, which is why the action is unable to run. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix job status display in scheduler template
Description
This PR updates
scheduler.htmlto correctly display the job status by usingjob.get_status.valueinstead ofjob.get_status.Changes
scheduler.html./django-rq/schedulers/<scheduler_id>/.Before Screenshot:
After Screenshot:
Testing