Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

bitswap: Update libp2p #490

Closed

Conversation

matthiasbeyer
Copy link

As suggsted in #485 I re-started my efforts starting with the /bitswap subtree for updating libp2p.

Supersedes #485


Feel free to suggest how to continue! 😆

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@koivunej
Copy link
Collaborator

Great you've been making progress, thanks also for Max (cannot tag from mobile ui) for helping out. I will be out of office until next week (xmas holidays) when I hope to fix the build and then merge this. Again, thanks for doing this!

Note that I only suggested that you'd start the upgrade from first getting the bitswap/ work, possibly leaving it implicit that you should continue to upgrade ipfs or the root crate after that. The libp2p upgrade should be on a single PR, even though it affects two parts or more parts (http/). Also, feel free to rebase your work on the PR as much as you want, just avoiding merges in the PR branch. However if the git-fu becomes an issue, I can take care of that when merging as well.

@matthiasbeyer
Copy link
Author

I will be out of office until next week

Sure, no hurry!

Note that I only suggested that you'd start the upgrade from first getting the bitswap/ work, possibly leaving it implicit that you should continue to upgrade ipfs or the root crate after that.

Yes, sure! Upgrading bitswap was ... doable, but I fail to see why the root crate does not compile, so I figured I rather push this into a PR and we go from there instead me just becoming desperate 😆

However if the git-fu becomes an issue, I can take care of that when merging as well.

No worries, I am a git ninja (>10 years experience, with different workflows and even email workflows etc etc)!

Copy link

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes itself look good to me.

Copy link
Collaborator

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good; compilation fails on your branch though, so the rest of the upgrade needs to be done on the ipfs side. If libp2p has already advanced to a next major version, then I'd suggest doing the ongoing upgrade first before moving on to the next.

driemworks added a commit to driemworks/rust-ipfs that referenced this pull request Mar 4, 2022
@koivunej
Copy link
Collaborator

koivunej commented Apr 1, 2022

Similar to #485, closing this as libp2p has been upgraded to 0.43.

@koivunej koivunej closed this Apr 1, 2022
@matthiasbeyer matthiasbeyer deleted the update-libp2p-bitswap branch April 1, 2022 14:14
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants