Address PR suggestion (minor refactoring)

rsksmart · Jun 10, 2021 · 6e6e16d · 6e6e16d
1 parent e67154b
commit 6e6e16d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/rskj-core/src/main/java/co/rsk/rpc/netty/Web3HttpStatusCodeProvider.java b/rskj-core/src/main/java/co/rsk/rpc/netty/Web3HttpStatusCodeProvider.java
@@ -27,7 +27,7 @@ public int getHttpStatusCode(int resultCode) {
                 HttpResponseStatus.OK.code();
     }
 
-    private boolean isBadRequestResultCode(int resultCode) {
+    private static boolean isBadRequestResultCode(int resultCode) {
         return BAD_REQUEST_JSON_ERRORS.contains(resultCode);
     }
 

diff --git a/rskj-core/src/main/java/co/rsk/rpc/netty/Web3ResultHttpResponseHandler.java b/rskj-core/src/main/java/co/rsk/rpc/netty/Web3ResultHttpResponseHandler.java
@@ -30,7 +30,7 @@
 
 public class Web3ResultHttpResponseHandler extends SimpleChannelInboundHandler<Web3Result> {
 
-    private HttpStatusCodeProvider httpStatusCodeProvider;
+    private final HttpStatusCodeProvider httpStatusCodeProvider;
 
     public Web3ResultHttpResponseHandler(HttpStatusCodeProvider httpStatusCodeProvider) {
         this.httpStatusCodeProvider = httpStatusCodeProvider;