Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

blockHash filter not recognized #1518

Closed
maxidev opened this issue May 3, 2021 · 0 comments
Closed

blockHash filter not recognized #1518

maxidev opened this issue May 3, 2021 · 0 comments

Comments

@maxidev
Copy link

maxidev commented May 3, 2021

Hi guys,
For my application (based on 0x/mesh protocol) I need the eth_getLogs() web3 method to be able to query the node using the filter "blockHash" to retrieve proper information about the block and transactions included in it, the result is a follows:

Result:
om.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "blockHash" (class org.ethereum.rpc.Web3$FilterRequest), not marked as ignorable (4 known properties: "toBlock", "fromBlock", "address", "topics"])

Expected Result:

Log data by block, like:

[
  {
    logIndex: 0,
    blockNumber: 1801710,
    blockHash: '0x69752508873b33a3f7ab005a3dd99dabed3e7725488d5f81c7c14e3f27eb8faf',
    transactionHash: '0x960064ee2661b5a51f6f1dae53fe6e71e6ff3291d2d353d3791d89f45d6943c9',
    transactionIndex: 0,
    address: '0x6189947146Ed06a1628b26793721b9b9bE899a33',
    data: '0x00000000000000000000000000000000000000000000001252b1393302080000',
    topics: [
      '0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef',
      '0x000000000000000000000000574366e84f74f2e913ad9a6782ce6ac8022e16eb',
      '0x000000000000000000000000bcd4d6443d4854cd254adc601ba113aff3697a04'
    ],
    id: 'log_68b39916'
  }
....
]

As the EIP-234 shows: https://eips.ethereum.org/EIPS/eip-234 this is proposed as an alternative to filter by block range and it is quite useful for latest developments.

Given that this is a common filter nowadays and being used by most latest developments for DeFi projects do you think that will be viable to include this in upcoming rskj node releases?
I think not only our project but the whole community will benefit from it.

Thank in advance

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants