Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support blockHash filter in eth_getLogs JSON-RPC method #1527

Merged
merged 2 commits into from
Jun 10, 2021
Merged

Support blockHash filter in eth_getLogs JSON-RPC method #1527

merged 2 commits into from
Jun 10, 2021

Conversation

marcciosilva
Copy link
Contributor

@marcciosilva marcciosilva commented May 10, 2021 •
edited
Loading

Description

Adds blockHash filter option to eth_getLogs JSON-RPC method, for convenience.

Motivation and Context

Fixes issue #1518

How Has This Been Tested?

Unit testing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)

@marcciosilva marcciosilva force-pushed the feature-support-block-hash-filter-in-eth-get-logs branch 2 times, most recently from 6a54a5d to 865d4e9 Compare May 11, 2021 14:24
@marcciosilva marcciosilva requested a review from Vovchyk May 11, 2021 19:20
@marcciosilva marcciosilva force-pushed the feature-support-block-hash-filter-in-eth-get-logs branch from 865d4e9 to 4cb8621 Compare May 11, 2021 19:22
@marcciosilva marcciosilva marked this pull request as ready for review May 11, 2021 21:51
@marcciosilva marcciosilva requested a review from fedejinich May 11, 2021 21:51
@marcciosilva
Copy link
Contributor Author

pipeline: run

fedejinich
fedejinich previously approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@fedejinich fedejinich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@marcciosilva
Copy link
Contributor Author

pipeline: run

1 similar comment
@marcciosilva
Copy link
Contributor Author

pipeline: run

@fedejinich
Copy link
Contributor

pipeline:run

@marcciosilva marcciosilva force-pushed the feature-support-block-hash-filter-in-eth-get-logs branch from a59d810 to d2b3b12 Compare June 10, 2021 13:38
fedejinich
fedejinich approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@fedejinich fedejinich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@aeidelman aeidelman merged commit 370955d into rsksmart:master Jun 10, 2021
@marcciosilva marcciosilva deleted the feature-support-block-hash-filter-in-eth-get-logs branch June 10, 2021 19:58
@aeidelman aeidelman added this to the Iris v3.1.0 milestone Jul 7, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fedejinich fedejinich fedejinich approved these changes

@Vovchyk Vovchyk Awaiting requested review from Vovchyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Iris 3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@marcciosilva @fedejinich @aeidelman