CLI Tools #1226
CLI Tools #1226
Conversation
|
This pull request introduces 3 alerts when merging 8ca08a1 into 0df03b4 - view on LGTM.com new alerts:
|
|
This pull request introduces 3 alerts when merging 0496d53 into 6c362f1 - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging 79745a9 into 6c362f1 - view on LGTM.com new alerts:
|
|
Kudos, SonarCloud Quality Gate passed!
|
| BlockStore blockStore = ctx.getBlockStore(); | ||
| ReceiptStore receiptStore = ctx.getReceiptStore(); | ||
|
|
||
| String filename = args[0]; |
There was a problem hiding this comment.
should we check the presence of the filename? same in the other classes
There was a problem hiding this comment.
The current code is oriented to be simple. We could improve the user experience if these tools are really used
| Block block = blockFactory.decodeBlock(encoded); | ||
| block.seal(); | ||
|
|
||
| blockchain.tryToConnect(block); |
There was a problem hiding this comment.
this returns a value that explains if the block has been connected or not. what happens if we don't check it?
There was a problem hiding this comment.
Nothing. The supplied blocks could be connected best ones, or only connect, or even invalid. One of the use case of this tool is to run the external blocks, maybe to check the execution logs
|
I would add a println that says "this is an experimental/unsupported tool" in each of these main classes just to make clear that these tools are not meant for regular node use. |
Well, I would prefer not pollute output with message, keep the first implementation simple, so we could improve them when we have more use pattern info |
|
Kudos, SonarCloud Quality Gate passed!
|
|
pipeline:run |
|
pipeline: run |
1 similar comment
|
pipeline: run |
|
pipeline:run |
1 similar comment
|
pipeline:run |
Command line tools: