Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixed issue with empty contract's return result #1352

Merged
merged 5 commits into from
Dec 28, 2020
Merged

Fixed issue with empty contract's return result #1352

merged 5 commits into from
Dec 28, 2020

Conversation

Vovchyk
Copy link
Contributor

@Vovchyk Vovchyk commented Nov 2, 2020 •
edited
Loading

This fixes compatibility issue for empty contracts return result.

Description

Empty contract return should be 0x, but it’s 0x00 instead.

Motivation and Context

To be compatible with Ethereum JSON-RPC clients 0x should be returned by eth_call for an empty contract instead of 0x00.

How Has This Been Tested?

Using unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)

fit: node-call-changes

@Vovchyk
Copy link
Contributor Author

Vovchyk commented Nov 2, 2020

pipeline: run

2 similar comments
@Vovchyk
Copy link
Contributor Author

Vovchyk commented Nov 6, 2020

pipeline: run

@Vovchyk
Copy link
Contributor Author

Vovchyk commented Nov 6, 2020

pipeline: run

patogallaiovlabs
patogallaiovlabs requested changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@patogallaiovlabs patogallaiovlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I didnt try it. I would change only those test asserts.

@Vovchyk Vovchyk force-pushed the empty-contract-return branch from 402cd25 to 3d3d090 Compare November 10, 2020 13:29
@Vovchyk Vovchyk force-pushed the empty-contract-return branch from 3d3d090 to 06da8b0 Compare November 19, 2020 17:34
ajlopezrsk
ajlopezrsk previously approved these changes Nov 19, 2020
View reviewed changes
patogallaiovlabs
patogallaiovlabs previously approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@patogallaiovlabs patogallaiovlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patogallaiovlabs patogallaiovlabs mentioned this pull request Dec 9, 2020
Closed
@patogallaiovlabs patogallaiovlabs linked an issue Dec 9, 2020 that may be closed by this pull request
JSON/RPC eth_getCode returns non-empty code for addresses that don't exist #1386
Closed
@Vovchyk Vovchyk dismissed stale reviews from patogallaiovlabs and ajlopezrsk via 5074d61 December 17, 2020 13:42
@Vovchyk Vovchyk force-pushed the empty-contract-return branch from 06da8b0 to 5074d61 Compare December 17, 2020 13:42
@Vovchyk
Copy link
Contributor Author

Vovchyk commented Dec 17, 2020

pipeline: run

1 similar comment
@Vovchyk
Copy link
Contributor Author

Vovchyk commented Dec 17, 2020

pipeline: run

ajlopezrsk
ajlopezrsk previously approved these changes Dec 17, 2020
View reviewed changes
@Vovchyk
Copy link
Contributor Author

Vovchyk commented Dec 17, 2020

pipeline: run

2 similar comments
@Vovchyk
Copy link
Contributor Author

Vovchyk commented Dec 17, 2020

pipeline: run

@josedahlquist
Copy link
Collaborator

pipeline: run

@Vovchyk Vovchyk force-pushed the empty-contract-return branch from 5074d61 to a8fec98 Compare December 28, 2020 17:20
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ajlopezrsk ajlopezrsk merged commit d9015dc into master Dec 28, 2020
@delete-merged-branch delete-merged-branch bot deleted the empty-contract-return branch December 28, 2020 17:55
@saurik
Copy link

saurik commented Apr 4, 2021

I also mentioned this on #1386, but this issue doesn't actually seem to be fixed yet?

@aeidelman aeidelman added this to the Iris v3.0.0 milestone Jul 7, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ajlopezrsk ajlopezrsk ajlopezrsk approved these changes

@patogallaiovlabs patogallaiovlabs patogallaiovlabs left review comments

Assignees
No one assigned
Labels
jsonrpc-change
Projects
None yet
Milestone
Iris 3.0.0
Development

Successfully merging this pull request may close these issues.

JSON/RPC eth_getCode returns non-empty code for addresses that don't exist
6 participants
@Vovchyk @josedahlquist @saurik @ajlopezrsk @patogallaiovlabs @aeidelman