[PAPYRUS-2.2.0-rc] Content type in JSON RPC response

[ajlopez]

fit: 2.2-rc

Description

Add a Content-Type header to JSON RPC responses, with value application/json to solve #1365 1365

Motivation and Context

Current code does not returns the content type header in the responses to JSON RPC invocations.

How Has This Been Tested?

It was tested using curl

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• Tests for the changes have been added (for bug fixes / features)
• Requires Activation Code (Hard Fork)

• Other information:

[fedejinich]

lgtm

[fedejinich]

pipeline:run

[ajlopezrsk]

pipeline:run

[lucasvuotto]

Correct me if I'm wrong, but I recall that RSK only returns JSON objects when the HTTP status is 200. The public node seems to confirm that:

$ curl -v -d '{"jsonrpc":"2.0","id":"pr1390","method":"eth_clientVersion"}' https://public-node.testnet.rsk.co/2.0.1 # note we aren't passing a "Content-Type: application/json" header
...
> POST /2.0.1 HTTP/2
> Host: public-node.testnet.rsk.co
> user-agent: curl/7.68.0
> accept: */*
> content-length: 60
> content-type: application/x-www-form-urlencoded
> 
* Connection state changed (MAX_CONCURRENT_STREAMS == 128)!
* We are completely uploaded and fine
< HTTP/2 415 
< date: Tue, 15 Dec 2020 17:41:15 GMT
< content-length: 0
< x-varnish-cache: MISS-1
< server: Flex
< x-powered-by: RSK Smart
< 
...

Will we be adding Content-Type: application/json to all the replies from the RPC server?

[ajlopezrsk]

AFAIK, only to responses that returns a co.rsk.rpc.netty.Web3Result El mar, 15 dic 2020 a las 14:43, Lucas (<notifications@github.com>) escribió:

…

Correct me if I'm wrong, but I recall that RSK only returns JSON objects when the HTTP status is 200. The public node seems to confirm that: $ curl -v -d '{"jsonrpc":"2.0","id":"pr1390","method":"eth_clientVersion"}' https://public-node.testnet.rsk.co/2.0.1 # note we aren't passing a "Content-Type: application/json" header ... > POST /2.0.1 HTTP/2 > Host: public-node.testnet.rsk.co > user-agent: curl/7.68.0 > accept: */* > content-length: 60 > content-type: application/x-www-form-urlencoded > * Connection state changed (MAX_CONCURRENT_STREAMS == 128)! * We are completely uploaded and fine < HTTP/2 415 < date: Tue, 15 Dec 2020 17:41:15 GMT < content-length: 0 < x-varnish-cache: MISS-1 < server: Flex < x-powered-by: RSK Smart < ... Will we be adding Content-Type: application/json to *all* the replies from the RPC server? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1390 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHVN5H26HFTYAZWVUDZ2RLDSU6N37ANCNFSM4USMGNGQ> .

[lucasvuotto]

pipeline: run

[alejandrod-iov]

piepline: run

[ajlopezrsk]

pipeline: run

[Vovchyk]

pipeline: run

[ajlopezrsk]

pipeline: run

[ajlopezrsk]

pipeline: run

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

The version of Java (1.8.0_275) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 11.
Read more here