Fixed issue with InetAddressBlock#contains when provided bits are 32 #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vovchyk
reviewed
Apr 12, 2022
Vovchyk
reviewed
Apr 22, 2022
Vovchyk
requested changes
Apr 27, 2022
rskj-core/src/main/java/co/rsk/scoring/InetAddressCidrBlock.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
Vovchyk
approved these changes
Apr 28, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue on address comparison for 32 bits accuracy. It was causing a bug when (un)banning addresses with subnet /32.
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: