Peer scoring review feature #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illuque-iov
force-pushed
the
peer_scoring_review_feature
branch
from
0990302 to
4f4fa17
Compare
|
pipeline:run |
Vovchyk
previously approved these changes
Jun 1, 2022
| @@ -433,4 +441,11 @@ private void removePendingMessage(long messageId, MessageType messageType) { | |||
| pendingMessages.remove(messageId); | |||
| logger.trace("Pending {}@{} REMOVED", messageType, messageId); | |||
| } | |||
|
|
|||
| private void logSyncIssue(Peer peer, String message, Object[] messageArgs) { | |||
| String completeMessage = "Node [{}] " + message; | |||
There was a problem hiding this comment.
return if ! logger.isTraceEnabled() ?
added 27 commits
June 16, 2022 10:01
…s failing with this branch codebasae: Issue 1) Current branch is adding some logs and node banning process was a bit slower. - node was banned, for 10ms (before, this was increased now) - we read node reputation expecting it false, but it was true already, node was forgiven because the 10ms had passed before our read Issue 2) Current branch is setting punishmentTime to 0 on endPunishment and merged test was not prepared for that
illuque-iov
force-pushed
the
peer_scoring_review_feature
branch
from
4f4fa17 to
e033b3f
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
pipeline:run |
Vovchyk
approved these changes
Jun 16, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes on Peer Scoring functionality in order to enable it on a paced way.
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: