Update getCode so it does not make a copy of the array #2365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the call to
Arrays.copyOf()
method and madegetCode()
return the array directly. As per @asoto-iov suggestion thegetCodeLength()
method.Motivation and Context
Currently the
doCODESIZE()
anddoCODECOPY()
methods can, under certain conditions, make a call to thegetCode()
method that returns a deep copy of the underlying array which can cause perfomance issues if the code array is too big.How Has This Been Tested?
Types of changes
Checklist: