Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add to field in trace responses #2431

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Conversation

rmoreliovlabs
Copy link
Contributor

Description

Pass codeAddress instead of null if the contract code is empty when creating a new call sub trace.

Motivation and Context

This is a reported bug. Traces generated from any trace_ api method do not include the to property in an action when in cases when action in question is a delegatecall to a non existent contract.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

@rmoreliovlabs rmoreliovlabs force-pushed the add_to_field_in_trace_responses branch from ac23981 to ed11529 Compare June 21, 2024 14:54
@Vovchyk
Copy link
Contributor

Vovchyk commented Jun 21, 2024

pipeline:run

Copy link

@Vovchyk Vovchyk merged commit 6fb9471 into master Jun 21, 2024
10 checks passed
@Vovchyk Vovchyk deleted the add_to_field_in_trace_responses branch June 21, 2024 16:44
@aeidelman aeidelman added this to the Arrowhead 6.3.0 milestone Jul 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants