chore: add java21 support #2640
Conversation
Vovchyk
force-pushed
the
vovchyk/java21-support
branch
5 times, most recently
from
482470b to
026ce0b
Compare
| - name: Setup Java JDK | ||
| uses: actions/setup-java@v3 | ||
| - name: Setup Java & Gradle | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: '17' |
There was a problem hiding this comment.
should not be updated to 21 aswell?
There was a problem hiding this comment.
interesting question.. I guess we should be targeting java17 as more stable one. But perhaps it'd make sense to run unit tests against both 17 and 21. Added that in this 1ddcfd7
|
|
||
| class MaxSizeHashMapTest { | ||
|
|
||
| @Test | ||
| void maxSizeMap_Test() { | ||
| int maxSize = 50_000; | ||
| void maxSizeMapTest() { |
There was a problem hiding this comment.
why was this test updated?
There was a problem hiding this comment.
there are couple of reasons: first, this test tries to "test" the feature not as a "blackbox", but an internal state of the instance of a system class. Secondly and mosts importantly, this test uses reflection to obtain an internal field of the system class (via field.setAccessible(true)), which is prohibited for non-open java packages in recent versions of junit. There's a workaround by opening system package (via --add-opens java.base/java.util=ALL-UNNAMED), but I'm not sure that worth it
|
Vovchyk
force-pushed
the
vovchyk/min-java-ver-bump
branch
from
e86e8f3 to
a808164
Compare
Vovchyk
force-pushed
the
vovchyk/java21-support
branch
from
1ddcfd7 to
0a5f8a2
Compare
Vovchyk
force-pushed
the
vovchyk/java21-support
branch
from
0a5f8a2 to
2cc5bef
Compare
|
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist:
fed:vovchyk/java21-support