Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(stableMinGasPrice): add extra logs #2807

Merged
merged 2 commits into from
Oct 18, 2024
Merged

feat(stableMinGasPrice): add extra logs #2807

merged 2 commits into from
Oct 18, 2024

Conversation

Vovchyk
Copy link
Contributor

@Vovchyk Vovchyk commented Oct 15, 2024

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

@Vovchyk Vovchyk requested a review from a team as a code owner October 15, 2024 16:29
@Vovchyk Vovchyk force-pushed the vovchyk/extra-stable-mgp-logs branch from eec8e4b to e3e6a60 Compare October 17, 2024 08:58
@Vovchyk Vovchyk changed the base branch from master to ARROWHEAD-6.4.0-rc October 17, 2024 08:58
fmacleal
fmacleal previously approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@fmacleal fmacleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good log addition, important to check how the new feature is working.

asoto-iov
asoto-iov previously approved these changes Oct 17, 2024
View reviewed changes
rmoreliovlabs
rmoreliovlabs previously approved these changes Oct 17, 2024
View reviewed changes
@Vovchyk Vovchyk dismissed stale reviews from rmoreliovlabs, asoto-iov, and fmacleal via de6014f October 17, 2024 15:42
@Vovchyk Vovchyk force-pushed the vovchyk/extra-stable-mgp-logs branch from e3e6a60 to de6014f Compare October 17, 2024 15:42
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

fmacleal
fmacleal approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@fmacleal fmacleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vovchyk Vovchyk merged commit a49e407 into ARROWHEAD-6.4.0-rc Oct 18, 2024
11 checks passed
@Vovchyk Vovchyk deleted the vovchyk/extra-stable-mgp-logs branch October 18, 2024 11:14
@aeidelman aeidelman added this to the Arrowhead 6.4.0 milestone Oct 30, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@asoto-iov asoto-iov asoto-iov approved these changes

@fmacleal fmacleal fmacleal approved these changes

@rmoreliovlabs rmoreliovlabs rmoreliovlabs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Arrowhead 6.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Vovchyk @rmoreliovlabs @asoto-iov @fmacleal @aeidelman