Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(traceBlockByNumber): add debug_traceBlockByNumber RPC method #2809

Merged
merged 3 commits into from
Oct 22, 2024
Merged

feat(traceBlockByNumber): add debug_traceBlockByNumber RPC method #2809

merged 3 commits into from
Oct 22, 2024

Conversation

Vovchyk
Copy link
Contributor

@Vovchyk Vovchyk commented Oct 17, 2024

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

fmacleal
fmacleal previously approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@fmacleal fmacleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Well done.

@Vovchyk Vovchyk force-pushed the vovchyk/trace-block-by-num branch from a98f6ec to cf0232f Compare October 18, 2024 11:15
fmacleal
fmacleal previously approved these changes Oct 21, 2024
View reviewed changes
@Vovchyk Vovchyk changed the base branch from ARROWHEAD-6.4.0-rc to master October 22, 2024 13:19
@Vovchyk Vovchyk dismissed fmacleal’s stale review October 22, 2024 13:19

The base branch was changed.

@Vovchyk Vovchyk requested a review from a team as a code owner October 22, 2024 13:19
@Vovchyk Vovchyk force-pushed the vovchyk/trace-block-by-num branch from cf0232f to 4c80d3f Compare October 22, 2024 13:20
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@Vovchyk Vovchyk merged commit 526931c into master Oct 22, 2024
10 of 11 checks passed
@Vovchyk Vovchyk deleted the vovchyk/trace-block-by-num branch October 22, 2024 15:08
@aeidelman aeidelman added this to the Arrowhead 6.5.0 milestone Dec 4, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fmacleal fmacleal fmacleal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Arrowhead 6.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Vovchyk @fmacleal @aeidelman