Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(rpc): add handling of null call args #2868

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix(rpc): add handling of null call args #2868

merged 1 commit into from
Dec 4, 2024

Conversation

Vovchyk
Copy link
Contributor

@Vovchyk Vovchyk commented Dec 2, 2024

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

fmacleal
fmacleal approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@fmacleal fmacleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the issue. Simple fix and straightforward, well done.

@Vovchyk Vovchyk force-pushed the vovchyk/null-args-fix branch from 2fef7e8 to bc624ec Compare December 4, 2024 08:54
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Vovchyk Vovchyk merged commit 7171fcc into master Dec 4, 2024
13 checks passed
@Vovchyk Vovchyk deleted the vovchyk/null-args-fix branch December 4, 2024 09:18
@aeidelman aeidelman added this to the Arrowhead 6.5.0 milestone Dec 4, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fmacleal fmacleal fmacleal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Arrowhead 6.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Vovchyk @fmacleal @aeidelman