Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Handle exception when removing signatures from a tx with non p2sh-legacy-multisig inputs #2979

Conversation

julia-zack
Copy link
Contributor

@julia-zack julia-zack commented Feb 5, 2025

fed:LOVELL-7.0.0-rc

Copy link

github-actions bot commented Feb 5, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@julia-zack julia-zack changed the base branch from master to lovell-700-rc-alphanet February 5, 2025 15:11
@julia-zack julia-zack force-pushed the catch_exception_when_removing_sigs_from_legacy_pegin branch 3 times, most recently from efe3573 to ed6a772 Compare February 5, 2025 16:13
@julia-zack julia-zack force-pushed the catch_exception_when_removing_sigs_from_legacy_pegin branch from ed6a772 to 4f21042 Compare February 5, 2025 17:14
@julia-zack julia-zack changed the base branch from lovell-700-rc-alphanet to LOVELL-7.0.0-rc February 5, 2025 17:26
@julia-zack julia-zack marked this pull request as ready for review February 5, 2025 20:17
@julia-zack julia-zack requested a review from a team as a code owner February 5, 2025 20:17
@julia-zack julia-zack changed the title Handle exception when removing signatures from a p2pkh sender Handle exception when removing signatures from a tx with non p2sh-legacy-multisig inputs Feb 5, 2025
Copy link
Contributor

@jeremy-then jeremy-then left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@josedahlquist josedahlquist merged commit 4e1d265 into LOVELL-7.0.0-rc Feb 6, 2025
12 checks passed
@aeidelman aeidelman added this to the Lovell 7.0.0 milestone Feb 12, 2025
@marcos-iov marcos-iov deleted the catch_exception_when_removing_sigs_from_legacy_pegin branch February 13, 2025 18:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants