This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
fix: fix token estimation of fees and transfer #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When trying to send a tx using a Token, an error occurred saying "Internal Error".
Issue
During the process of building the tx, we mix inside the code the use of "checksum vs lowercase". In this case, I think it was an incompatibility between library checksums, but the real matter it is that we don't need it in order to operate with the network. Checksums are only needed for user, when interacting with addresses as a second factor of verification.
Final fix
As this fix doesn't actually change that verification (it is made in another level), we send lowercase address as the final address in the transaction.