Fix: WebSocket Duplex Connection Unhandled Exceptions #278
+76
−74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some potential unhandled exceptions in
rsocket-websocket-server
relating to the underlying WebSocketreadyState
and deserialisation of invalid frames.Motivation:
I've noticed intermittent unhandled exceptions for the errors below:
WebSocket is in CLOSING state:
Unable to read
type
of undefined frame:Modifications:
WebSocket readyState
The WebSocket from the
ws
library is now used to check thereadyState
before callingwrite
on the Duplex stream.Undefined frame:
I believe this error was caused by the
deserializeFrame
method returning undefined. This could be verified by a client connecting to the server WebSocket port and sending a random Buffer payload.The connection will now close if no valid frame could be deserialised.
Result:
The external API and behaviour should be the same as before. There should now be less potential for unhandled exceptions.
Side Note:
I've noticed some formatting changes were included here. Is there perhaps a Prettier config I could use? Running
yarn lint
on my machine also shows errors for other package's files. Perhaps this is somehow linking to external settings I might have. Please advise.