Skip to content

Improve chat sample #196

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from Jan 12, 2022
Merged

Improve chat sample #196

merged 1 commit into from Jan 12, 2022

Conversation

ghost
Copy link

@ghost ghost commented Dec 16, 2021 •
edited by ghost
Loading

  • Make chat sample separate project under samples folder
  • Split sample code in 3 modules: api, client and server
  • Make server running on K/N
  • Use rsocket-kotlin 0.14.3
  • Add simple README for sample

@ghost ghost marked this pull request as draft December 21, 2021 12:19
Improve chat sample
09206f6 
* move chat sample to separate project under `samples` folder
* make it possible to run same server on both JVM and Native with minimal differences
* use rsocket-kotlin 0.14.3
@ghost ghost changed the title Make multiplatform chat sample an included build and rework it Improve chat sample Dec 21, 2021
@ghost ghost marked this pull request as ready for review December 21, 2021 15:03
@ghost
Copy link
Author

ghost commented Dec 21, 2021

@OlegDokuka @yschimke PR is ready for review :)

@whyoleg whyoleg merged commit 388fcc9 into rsocket:master Jan 12, 2022
@ghost ghost deleted the task/build/4-chat-sample branch January 12, 2022 07:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@whyoleg