Skip to content

Ktor usage cleanup #288

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Feb 9, 2025
Merged

Ktor usage cleanup #288

merged 3 commits into from
Feb 9, 2025

Conversation

whyoleg
Copy link
Member

@whyoleg whyoleg commented Feb 9, 2025

Modifications:

  • drop unused dependencies after migration to kotlinx-io
  • drop old client websocket tests and different engines
    • with ktor 3.1 CIO will be supported for all targets and so it will be enough to test the logic with it on all targets
  • extract websocket tests to separate modules

@whyoleg whyoleg self-assigned this Feb 9, 2025
Copy link

github-actions bot commented Feb 9, 2025

Test Results

  862 files   -  16    862 suites   - 16   32m 15s ⏱️ - 6m 58s
3 777 tests  -  96  3 062 ✅  -  72    715 💤  - 24  0 ❌ ±0 
7 944 runs   - 384  6 418 ✅  - 288  1 526 💤  - 96  0 ❌ ±0 

Results for commit 06539d0. ± Comparison against base commit aeaf294.

♻️ This comment has been updated with latest results.

@whyoleg whyoleg merged commit 8fd223d into master Feb 9, 2025
20 checks passed
@whyoleg whyoleg deleted the ktor-cleanup branch February 9, 2025 14:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant