Use consistent naming for request specs

Controller generators are using a different naming scheme for requests specs that are now generated by default. Use always `spec/requests/posts_spec.rb` by default. This
rspec · Sep 2, 2020 · 4b511aa · 4b511aa
1 parent c360f35
commit 4b511aa
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/example_app_generator/generate_stuff.rb b/example_app_generator/generate_stuff.rb
@@ -85,7 +85,10 @@ def using_source_path(path)
 generate('rspec:install')
 generate('controller wombats index') # plural
 generate('controller welcome index') # singular
-generate('rspec:request wombats')
+
+# request specs are now the default
+generate('rspec:controller wombats --no-request-specs --controller-specs --no-view-specs')
+
 generate('integration_test widgets')
 generate('mailer Notifications #')
 

diff --git a/lib/generators/rspec/controller/controller_generator.rb b/lib/generators/rspec/controller/controller_generator.rb
@@ -16,7 +16,7 @@ def generate_request_spec
         return unless options[:request_specs]
 
         template 'request_spec.rb',
-                 File.join('spec/requests', class_path, "#{file_name}_request_spec.rb")
+                 File.join('spec/requests', class_path, "#{file_name}_spec.rb")
       end
 
       def generate_controller_spec

diff --git a/spec/generators/rspec/controller/controller_generator_spec.rb b/spec/generators/rspec/controller/controller_generator_spec.rb
@@ -6,7 +6,7 @@
   setup_default_destination
 
   describe 'request specs' do
-    subject { file('spec/requests/posts_request_spec.rb') }
+    subject { file('spec/requests/posts_spec.rb') }
 
     describe 'generated by default' do
       before do
@@ -38,7 +38,7 @@
     end
 
     describe 'with namespace and actions' do
-      subject { file('spec/requests/admin/external/users_request_spec.rb') }
+      subject { file('spec/requests/admin/external/users_spec.rb') }
 
       before do
         run_generator %w[admin::external::users index custom_action]