-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Integration generator deprecation #2387
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
TODO: test out the scaffolds generation |
82f211e
to
7b47f79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the scaffold integration: Fine ✔️
I tried the test suite out what happens lib/generators/rspec/integration/integration_generator.rb
is deleted. This helped to catch the now unnecessary require 'generators/rspec/integration/integration_generator'
statement 😁
7b47f79
to
3b6f8f0
Compare
3b6f8f0
to
6d75158
Compare
and break the inheritance. IntegrationGenerator will get a deprecation so the inheritance made no sense.
6d75158
to
0b29fdd
Compare
0b29fdd
to
fe42d6b
Compare
Thank you! |
@pirj No Problemo. I don't even remember doing this 😂 |
Closes #2374
With these changes executing
rails generate rspec:integration
produces the following messageTest Plan