-
Notifications
You must be signed in to change notification settings - Fork 60
feat(card): Report full screen state as a Shiny input #1006
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Please do rebase off main as I have more reservations about that PR. |
cpsievert
reviewed
Mar 12, 2024
cpsievert
reviewed
Mar 12, 2024
a852d27
to
4fac944
Compare
4fac944
to
10db8b2
Compare
10db8b2
to
d838ccb
Compare
cpsievert
reviewed
Mar 13, 2024
cpsievert
approved these changes
Mar 13, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #962
When
card()
is given anid
, e.g.card(id = "my_card")
, the full screen state of the card is now reported asinput$my_card$full_screen
.Note: this PR builds on #1005 but could be rebased on
main
to decouple.Example