Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add sidebars #479

Merged
merged 79 commits into from
Mar 4, 2023
Merged

Add sidebars #479

merged 79 commits into from
Mar 4, 2023

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Jan 24, 2023

See the NEWS.md for a summary of what this PR does.

Closes #480 (as a side-effect)

TODO

  • Automated tests
  • Add bindCache() to flights demo

TODO (in follow-up PRs)

  • Add fillable = fill argument to shiny::uiOutput(). Deprecate "container"/"item" value.
  • Add a card_body_fillable() alias for card_body_fill() (and make the latter @Keywords internal?)
  • Add a page_fillable() alias for page_fill()?
  • Get rid of fill argument in layout_column_wrap() and instead add that behavior as a heights_equal option?
  • Consider renaming fillable to fillable_panel once we've renamed nav() to nav_panel() (Add nav_panel() alias for nav() and navset_*() aliases for navs_*() #476)

@cpsievert cpsievert marked this pull request as draft January 25, 2023 21:28
@cpsievert cpsievert changed the title Add sidebar(), layout_sidebar(), card_sidebar(), and container() Add sidebar(), layout_sidebar(), card_sidebar(), and contain_width() Feb 7, 2023
@jcheng5 jcheng5 self-requested a review February 23, 2023 23:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested nav containers
2 participants