Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Have page_navbar() default to fillable = TRUE #589

Merged
merged 27 commits into from
May 31, 2023
Merged

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented May 19, 2023

Partially addresses #569

Note that, although shiny::navbarPage() passes it's arguments to page_navbar(), this change shouldn't impact most existing navbarPage() code since the fillable = TRUE logic is implemented in CSS that only comes from bslib (thus, you need theme = bs_theme() to activate it):

# The `theme = bs_theme()` is needed in order for fillable = TRUE to work
navbarPage(title = "foo", fillable = TRUE, tabPanel("Plot", plotly::plot_ly()), theme = bs_theme()) |>
  browsable()

@cpsievert cpsievert requested a review from gadenbuie May 19, 2023 21:45
@cpsievert cpsievert mentioned this pull request May 22, 2023
1 task
@cpsievert cpsievert merged commit e77dbc8 into main May 31, 2023
@cpsievert cpsievert deleted the page-navbar-fillable branch May 31, 2023 22:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants