Simplify sidebar getValue input binding method #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small follow up to #603 to simplify the
getValue()method of the sidebar input binding.See conversation in #603 (comment)
This also fixes #636 by updating the events emitted when the sidebar state is finalized by triggering
{shown|hidden}.sendOutputHiddenStatejquery events on the sidebar.While here, I also added a browser-native event. In the future, we could use this browser event to separate all uses of jQuery from the
Sidebarclass, so that we could progressively enhance the sidebar in the presence of Shiny (and jQuery). That's left for a future PR, but this change puts us in a better spot for that update.