feat(card): Use an attribute to signal card is in full screen #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows us to use [data-full-screen] to know card has full screen capabilities Or [data-full-screen="false"] to know card is collapsed (or ="true" to know it's expanded)
gadenbuie
changed the title
Merged
|
Seems ok to me but tagging @schloerke since he's been writing tests around this recently |
cpsievert
approved these changes
Jul 12, 2023
cpsievert
pushed a commit
that referenced
this pull request
Jul 12, 2023
This was referenced Jul 13, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a card supports full screen expansion, we add the expand toggle button but there isn't anything that signals from the outer element that full screen expansion is possible.
This PR adds a
.bslib-card[data-full-screen]to signal that a card has full screen capabilities and to track the full screen state. This means you can use[data-full-screen]to know that card can expand,[data-full-screen="false"]to know card is not full screen, or[data-full-screen="true"]to know it's expanded.