Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix use of rlang::is_string() inside of toggle_switch() #792

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Sep 11, 2023

Introduced by #709. Fixes the following error (discovered through and will fix https://rstudio.github.io/shinycoreci/results/2023/09/11/#315-bslib-input-switch)

library(shiny)
library(bslib)

ui <- page_fixed(
  input_switch("x", "Switch")
)

server <- function(input, output, session) {
  toggle_switch("x")
}

shinyApp(ui, server)
Error in rlang::is_string(id, n = 1) : unused argument (n = 1)

Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops 🙊 thank you!

@cpsievert cpsievert merged commit 2573d2d into main Sep 11, 2023
@cpsievert cpsievert deleted the toggle-switch-fix branch September 11, 2023 15:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants