Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(shiny-preset): Add bslib-page-dashboard for grey background #906

Merged
merged 6 commits into from
Nov 16, 2023

Conversation

gadenbuie
Copy link
Member

@gadenbuie gadenbuie commented Nov 15, 2023

This update uses a white (i.e. unset) background color for the main content area everywhere. In page_navbar(), page_sidebar(), page_fillable() or page(), users can set class = "bslib-page-sidebar" to get the full dashboard treatment.

Style page_navbar() page_sidebar()
Default image image
Dash image image

@gadenbuie gadenbuie requested a review from cpsievert November 15, 2023 19:11
@gadenbuie gadenbuie self-assigned this Nov 15, 2023
Copy link
Collaborator

@cpsievert cpsievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's also make sure we have a sensible way to put the gray background on page_navbar() examples

@gadenbuie gadenbuie merged commit 07717dd into main Nov 16, 2023
@gadenbuie gadenbuie deleted the preset/dashboard-bg-default branch November 16, 2023 03:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants