fix(navbar): Validate gap
and padding
early
#991
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #761,
page_navbar(padding = 24)
isn't handled in the same way aslayout_sidebar(padding = 24)
. In the second case, we passpadding
throughvalidateCssPadding()
, which resovles24
to"24px"
.In
page_navbar()
,gap
andpadding
are handed down to many lower-level functions until they're actually used. I think there was an assumption that one of those function would handle the validation.For the best user experience (finding out early with a reasonable traceback), I've added early validation of these values in
page_navbar()
andnavset_bar()
. I also modifiedvalidateCssPadding()
to returnNULL
in the base case, which makes it easier to perform the checks and matchesvalidateCssUnit()
.