Clean up evaluation error tooltips in agent report #543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a minor QoL visual change to the contents of the tooltip text for evaluation errors in the agent report.
Before:
After:
Note that the error object with the full context is still available in
$capture_stack$error
, if one wanted to diagnose it more seriously.Implementational details:
validation_set$capture_stack
now tracks an additional information about the call passed topointblank_try_catch()
, in$pb_call
:Two unit tests were updated to reflect this change to the contents of
$capture_stack
.This information about the pointblank-internal call lays dormant in the agent, and is only consumed at
get_agent_report()
as part of formatting the error objects to string before rendering to html<title>
. This is handled by a new internal functionpointblank_cnd_to_string()
.Note that warning objects turned out to be are somewhat more complicated to work with, so the reformatting currently only applies to errors.