Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use check_installed() + drop crayon from Suggests #559

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Use check_installed() + drop crayon from Suggests #559

merged 3 commits into from
Aug 6, 2024

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Aug 5, 2024 •
edited
Loading

Summary

cli::make_ansi_style() seems to be a drop-in replacement for crayon::make_style() ?

Also use rlang::check_installed() for handling missing packages.

Checklist

@rich-iannone rich-iannone self-requested a review August 6, 2024 20:18
rich-iannone
rich-iannone approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rich-iannone rich-iannone merged commit a147ccb into rstudio:main Aug 6, 2024
12 checks passed
@olivroy olivroy deleted the check-installed branch November 27, 2024 21:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rich-iannone rich-iannone rich-iannone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olivroy @rich-iannone