fix handling of named remotes (closes #2055)

NEWS.md

@@ -1,6 +1,9 @@
 
 # renv 1.1.0  (UNRELEASED)
 
+* Fixed an issue where `renv::init()` could fail when using named remotes
+  in a DESCRIPTION file's `Remotes:` field. (#2055)
+
 * Fixed an issue where ignore rules of the form `!*.*` were not parsed
   and handled correctly during dependency discovery. (#2052)
 

R/hydrate.R

@@ -93,8 +93,21 @@ hydrate <- function(packages = NULL,
   # also consider remotes; if a package is listed within Remotes,
   # then choose to install that package instead of linking it
   filter <- function(specs, remotes) {
-    packages <- map_chr(remotes, `[[`, "Package")
+
+    packages <- enum_chr(remotes, function(package, remote) {
+
+      # if we have a package name, use it
+      if (is.character(package) && nzchar(package))
+        return(package)
+
+      # otherwise, resolve the remote and use the package field
+      remote <- resolve(remote)
+      remote[["Package"]]
+
+    })
+
     keep(specs, packages)
+
   }
 
   remotes <- renv_project_remotes(project, filter = filter, resolve = TRUE)

R/remotes.R

@@ -21,6 +21,11 @@ renv_remotes_resolve <- function(spec, latest = FALSE) {
   if (is.null(spec) || is.list(spec))
     return(spec)
 
+  # check for a package name prefix and remove it
+  regexps <- .standard_regexps()
+  pattern <- sprintf("^%s=", regexps$valid_package_name)
+  spec <- sub(pattern, "", spec)
+
   # remove a trailing slash
   # https://github.com/rstudio/renv/issues/1135
   spec <- gsub("/+$", "", spec, perl = TRUE)

tests/testthat/test-init.R

@@ -269,3 +269,19 @@ test_that("init() respects Remotes in a project DESCRIPTION file", {
   init()
   expect_true(renv_package_installed("skeleton"))
 })
+
+test_that("a project using named remotes can be initialized", {
+  project <- renv_tests_scope()
+
+  contents <- heredoc('
+    Depends:
+      toast
+    Remotes:
+      toast=toast
+  ')
+  writeLines(contents, con = "DESCRIPTION")
+
+  init(settings = list(snapshot.type = "explicit"))
+  expect_true(renv_package_installed("toast"))
+
+})