Skip to content
This repository was archived by the owner on Oct 27, 2020. It is now read-only.

Add support for multilingual gitbooks #2

Merged
merged 2 commits into from
Apr 3, 2015
Merged

Conversation

aniav
Copy link
Contributor

@aniav aniav commented Mar 28, 2015

In our multilingual book: https://github.com/DjangoGirls/ your plugin was generating wrong links, without the language prefix. I have created this change and as far as I checked it works properly with plain books and with the multilingual ones, but I am not sure how much "hacky" this solution is. I am not sure how gitbook handles languages.

Any comments are much appreciated. Thank you!

@rahul286
Copy link
Member

@aniav thanks for PR. :-)

I never used multilingual feature of gitbook so no idea if PR is correct.

I am copying @SamyPesse. May be he can guide.

@SamyPesse
Copy link
Contributor

This will not work with GitBook 2.0.0, but I'm going to add back support for originalInput.

@aniav you should use:

var path = require("path");

...

path.relative(this.options.originalInput, page.rawPath)

SamyPesse added a commit to GitbookIO/gitbook that referenced this pull request Mar 30, 2015
@aniav
Copy link
Contributor Author

aniav commented Mar 30, 2015

I have updated the file with your suggestion. Thank you! ✨

@SamyPesse
Copy link
Contributor

You're welcome 👍

@aniav
Copy link
Contributor Author

aniav commented Apr 2, 2015

@rahul286 I believe this can be merged now :)

@SamyPesse
Copy link
Contributor

👍 and gitbook 2.0.1 has been released and is in production on gitbook.com to handle originalInput.

rahul286 added a commit that referenced this pull request Apr 3, 2015
Add support for multilingual gitbooks
@rahul286 rahul286 merged commit 3b6667d into rtCamp:master Apr 3, 2015
@rahul286
Copy link
Member

rahul286 commented Apr 3, 2015

@aniav and @SamyPesse thanks. :-)

Merged PR.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants