Performance Improvement when querying tags on model especially for models with lots of records and with tags #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love it, thank you for sharing this with the rest of us |
|
Release 4.1.3 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
None
Issues
When using laravel-tagging with models that has tags but lots of records, there is a performance issues when using withAnyTags to retrieve particular models with specific tags. The 'where In' clause for the query will also show duplicate TagIds in the resulting eloquent queries.
What does this implement/fix? Explain your changes.
In the codes where it pluck('taggable_id'), I've included laravel collection method unique() to remove this duplicate TagIds. This reduce the number of tags included in the 'Where In' clause of the model and increase performance by roughly 40%.
Any other comments?
No