Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Warn about PR problems in docs. Refs #16, #36, #350. #370

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from

Conversation

pkienzle
Copy link

I assert that this patch is my own work, and to simplify the licensing of the BFG Repo-Cleaner:

(choose 1 of these 2 options)

  • I assign the copyright on this contribution to Roberto Tyley
  • I disclaim copyright and thus place this contribution in the public domain

I ran BFG on a repo with pull requests, which was ultimately not useful since the history I was trying to remove is still accessible. This is already reported in #16, #36, #350. I want to warn future me (and other users) that this was the case so I updated the docs.

I suggest rebasing all dependent PRs on the revised commit hashes. I have not yet tried it but it ought to help.

@pkienzle
Copy link
Author

Okay, I did try updating the head of the PR to the new commit hash (the easy way, with a force push to the corresponding commit number) but the details of the already merged PR did not change. I removed my suggested mitigation, but left the references to the issues where the problem is discussed.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant