Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Fix #79] Fix false positives for FactoryBot/AssociationStyle with strategy: :create option. #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Fix #79] Fix false positives for FactoryBot/AssociationStyle with strategy: :create option. #141

wants to merge 1 commit into from

Conversation

ydakuka
Copy link

@ydakuka ydakuka commented Feb 20, 2025

Fix #79

Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

  • Added the new cop to config/default.yml.
  • The cop is configured as Enabled: pending in config/default.yml.
  • The cop documents examples of good and bad code.
  • The tests assert both that bad code is reported and that good code is not reported.
  • Set VersionAdded: "<<next>>" in default/config.yml.

If you have modified an existing cop's configuration options:

  • Set VersionChanged: "<<next>>" in config/default.yml.

@ydakuka ydakuka requested a review from a team as a code owner February 20, 2025 10:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positives on FactoryBot/AssociationStyle cop
1 participant
@ydakuka