Merge pull request #290 from koic/fix_a_false_positive_for_performanc…

…e_string_identifier_argument [Fix #289] Fix a false positive for `Performance/StringIdentifierArgument`
rubocop · May 21, 2022 · 9dba637 · 9dba637
2 parents 11dd588 + b0b47e7
commit 9dba637
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/changelog/fix_a_false_positive_for_performance_string_identifier_argument.md b/changelog/fix_a_false_positive_for_performance_string_identifier_argument.md
@@ -0,0 +1 @@
+* [#289](https://github.com/rubocop/rubocop-performance/issues/289): Fix a false positive for `Performance/StringIdentifierArgument` when using namespaced class string argument. ([@koic][])
diff --git a/lib/rubocop/cop/performance/string_identifier_argument.rb b/lib/rubocop/cop/performance/string_identifier_argument.rb
@@ -46,7 +46,7 @@ class StringIdentifierArgument < Base
         def on_send(node)
           return unless (first_argument = node.first_argument)
           return unless first_argument.str_type?
-          return if first_argument.value.include?(' ')
+          return if first_argument.value.include?(' ') || first_argument.value.include?('::')
 
           replacement = first_argument.value.to_sym.inspect
 

diff --git a/spec/rubocop/cop/performance/string_identifier_argument_spec.rb b/spec/rubocop/cop/performance/string_identifier_argument_spec.rb
@@ -38,6 +38,18 @@
     RUBY
   end
 
+  it 'does not register an offense when using cbase class string argument' do
+    expect_no_offenses(<<~RUBY)
+      Object.const_defined?('::Foo')
+    RUBY
+  end
+
+  it 'does not register an offense when using namespaced class string argument' do
+    expect_no_offenses(<<~RUBY)
+      Object.const_defined?('Foo::Bar')
+    RUBY
+  end
+
   it 'does not register an offense when using symbol argument for no identifier argument' do
     expect_no_offenses(<<~RUBY)
       foo('do_something')