Enhance Performance/StringInclude to handle === method

changelog/change_string_include_to_handle_===.md

@@ -0,0 +1 @@
+* [#395](https://github.com/rubocop/rubocop-performance/issues/395): Enhance `Performance/StringInclude` to handle `===` method. ([@fatkodima][])

lib/rubocop/cop/performance/string_include.rb

@@ -16,18 +16,19 @@ module Performance
       #   /ab/ =~ str
       #   str.match(/ab/)
       #   /ab/.match(str)
+      #   /ab/ === str
       #
       #   # good
       #   str.include?('ab')
       class StringInclude < Base
         extend AutoCorrector
 
         MSG = 'Use `%<negation>sString#include?` instead of a regex match with literal-only pattern.'
-        RESTRICT_ON_SEND = %i[match =~ !~ match?].freeze
+        RESTRICT_ON_SEND = %i[match =~ !~ match? ===].freeze
 
         def_node_matcher :redundant_regex?, <<~PATTERN
           {(call $!nil? {:match :=~ :!~ :match?} (regexp (str $#literal?) (regopt)))
-           (send (regexp (str $#literal?) (regopt)) {:match :match?} $_)
+           (send (regexp (str $#literal?) (regopt)) {:match :match? :===} $_)
            (match-with-lvasgn (regexp (str $#literal?) (regopt)) $_)}
         PATTERN
 

spec/rubocop/cop/performance/string_include_spec.rb

@@ -147,6 +147,29 @@
   include_examples('different match methods', ' =~')
   include_examples('different match methods', '.match')
 
+  it 'registers an offense and corrects /abc/ === str' do
+    expect_offense(<<~RUBY)
+      /abc/ === 'str'
+      ^^^^^^^^^^^^^^^ Use `String#include?` instead of a regex match with literal-only pattern.
+    RUBY
+
+    expect_correction(<<~RUBY)
+      'str'.include?('abc')
+    RUBY
+  end
+
+  it 'does not register an offense for str === /abc/' do
+    expect_no_offenses(<<~RUBY)
+      str === /abc/
+    RUBY
+  end
+
+  it 'does not register an offense when receiver of `===` is not a simple regexp' do
+    expect_no_offenses(<<~RUBY)
+      /abc[de]/ === str
+    RUBY
+  end
+
   it 'allows match without a receiver' do
     expect_no_offenses('expect(subject.spin).to match(/\A\n/)')
   end