Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Fix #111] Fix an error for Performance/DeletePrefix and Performance/DeleteSuffix cops #113

Merged

Conversation

koic
Copy link
Member

@koic koic commented May 22, 2020

Fixes #111.

This PR fixes an error for Performance/DeletePrefix and Performance/DeleteSuffix cops when using autocorrection with RuboCop 0.81 or lower.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

…rformance/DeleteSuffix`

Fixes rubocop#111.

This PR fixes an error for `Performance/DeletePrefix` and `Performance/DeleteSuffix` cops
when using autocorrection with RuboCop 0.81 or lower.
@koic koic force-pushed the fix_an_error_for_delete_prefix_and_delete_suffix branch from 21ccc60 to 49ea20f Compare May 22, 2020 02:46
@koic koic changed the title Fix an error for Performance/DeletePrefix and Performance/DeleteSuffix cops [Fix #111] Fix an error for Performance/DeletePrefix and Performance/DeleteSuffix cops May 22, 2020
@koic koic merged commit 268a435 into rubocop:master May 23, 2020
@koic koic deleted the fix_an_error_for_delete_prefix_and_delete_suffix branch May 23, 2020 06:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crash in Performance/DeletePrefix with 1.6.0
1 participant