Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Fix #70] Fix a false negative for Performance/FlatMap #76

Merged

Conversation

koic
Copy link
Member

@koic koic commented Sep 8, 2019

Fixes #70.

This PR fixes a false negative for Performance/FlatMap when using symbol to proc operator argument of map method.

@splattael I write your account both credit in the changelog. Thanks!


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Fixes rubocop#70.

This PR fixes a false negative for `Performance/FlatMap`
when using symbol to proc operator argument of `map` method.
@koic koic merged commit 74b3186 into rubocop:master Oct 1, 2019
@koic koic deleted the fix_false_negative_for_performance_flat_map branch October 1, 2019 19:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance/FlatMap does not work with block_pass
1 participant