Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

New Cop: UnusedImplicitSubject #1040

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcandre
Copy link
Contributor

Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

  • Added the new cop to config/default.yml.
  • The cop is configured as Enabled: pending in config/default.yml.
  • The cop documents examples of good and bad code.
  • The tests assert both that bad code is reported and that good code is not reported.
  • Set VersionAdded in default/config.yml to the next minor version.

@marcandre
Copy link
Contributor Author

marcandre commented Oct 13, 2020

Hmmm. I now realize it contradicts RSpec/ImplicitSubject and maybe I should have modified that instead.

I had read quickly that cop, but got confused by the fact that it deals with two things that aren't related in my mind:

  • use of it_is_expected vs expect(subject)
  • number of lines / expectactions / whatever

@marcandre marcandre marked this pull request as draft October 13, 2020 05:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant